Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 3.11 #87

Merged
merged 3 commits into from
Aug 28, 2023
Merged

python 3.11 #87

merged 3 commits into from
Aug 28, 2023

Conversation

airportyh
Copy link
Collaborator

@airportyh airportyh commented Aug 25, 2023 •
edited
Loading

Why

Want to add Python 3.11 module.

What changed

  1. because debugpy has known bugs on Python 3.11, disabled it for python-3.11.
  2. Built and referenced new Poetry bundle for python 3.11.
  3. Refactored poetry-in-venv setup.
  4. renamed community-version to PythonVersion because we don't really call it that anymore

Test plan

@airportyh airportyh force-pushed the th-python-11 branch 4 times, most recently from afe7a4d to a3c2eb3 Compare August 28, 2023 18:45
@airportyh airportyh marked this pull request as ready for review August 28, 2023 18:52
@airportyh airportyh requested a review from a team as a code owner August 28, 2023 18:52
@airportyh airportyh requested review from ryantm and removed request for a team August 28, 2023 18:52
ryantm
ryantm approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@airportyh airportyh merged commit b70ef78 into main Aug 28, 2023
@airportyh airportyh deleted the th-python-11 branch August 28, 2023 20:38
@blast-hardcheese blast-hardcheese mentioned this pull request Oct 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airportyh @ryantm