chore/avoid bespoke protocol #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
changed the title
blast-hardcheese
force-pushed
the
dstewart/chore/linting
branch
10 times, most recently
from
ce0664d
to
f0fac96
Compare
blast-hardcheese
force-pushed
the
dstewart/chore/avoid-bespoke-protocol
branch
from
4e57c85
to
7738f54
Compare
blast-hardcheese
force-pushed
the
dstewart/chore/avoid-bespoke-protocol
branch
from
7738f54
to
7c208be
Compare
masad-frost
reviewed
Nov 20, 2024
| return JSON.parse(line); | ||
| } catch (e) { | ||
| // Sometimes docker injects this into the stream: | ||
| // {"hijack":true,"stream":true,"stdin":true,"stdout":true,"stderr":true}{"type": "invoke", ... |
masad-frost
approved these changes
Nov 20, 2024
| @@ -13,7 +13,6 @@ import DockerModem from 'docker-modem'; | |||
| import logUpdate from 'log-update'; | |||
| import { PassThrough } from 'stream'; | |||
| import { | |||
| serializeInvokeAction, | |||
There was a problem hiding this comment.
Delete this function from export site pls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust implementations to just use the IR as the protocol.
Benefits:
grepacross network boundariesDrawbacks: