3.1.0 switch to rustix again for glibc compat #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
changed the title
lhchavez
reviewed
Jun 11, 2024
index.d.ts
Outdated
| @@ -27,7 +27,7 @@ export class Pty { | |||
| * Returns a file descriptor for the PTY controller. | |||
| * See the docstring of the class for an usage example. | |||
| */ | |||
| fd(): c_int | |||
| fd(): RawFd | |||
There was a problem hiding this comment.
i don't think this is a legit type, ha. how can we make this return number?
src/lib.rs
Outdated
| @@ -272,7 +269,7 @@ impl Pty { | |||
| /// See the docstring of the class for an usage example. | |||
| #[napi] | |||
| #[allow(dead_code)] | |||
| pub fn fd(&mut self) -> Result<c_int, napi::Error> { | |||
| pub fn fd(&mut self) -> Result<RawFd, napi::Error> { | |||
There was a problem hiding this comment.
Suggested change
| pub fn fd(&mut self) -> Result<RawFd, napi::Error> { | |
| pub fn fd(&mut self) -> Result<i32, napi::Error> { |
it's disgusting, but i think we need to cast this to i32 so that the codegen emits a nice number https://napi.rs/docs/concepts/function
src/lib.rs
Outdated
Comment on lines
200
to
201
| let controller_fd = unsafe { OwnedFd::from_raw_fd(raw_controller_fd) }; | ||
| poll_controller_fd_until_read(controller_fd); |
There was a problem hiding this comment.
hmm i think this is unsafe, because we don't truly own the raw controller fd in this context, and exiting the poll will .close it! but then we will .close it again in .close()!!!
we probably need to reintroduce the fd copying that we had earlier 😭.
|
this is a lil borked, closing for now and trying ubuntu-2004 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.