3.1.0 Add functions to get/set the close-on-exec flag #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhchavez
force-pushed
the
lh-cloexec
branch
2 times, most recently
from
001889d
to
7468b65
Compare
jackyzha0
approved these changes
Jul 9, 2024
pid2 needs to set the close-on-exec flag on a certain file descriptor, but node doesn't have an API to achieve this. The only other node module that provides the `fcntl(2)` binding doesn't play well with esbuild, so we need to recruit the help of our friend here. This change adds two functions to get/set the close-on-exec flag on a file descriptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pid2 needs to set the close-on-exec flag on a certain file descriptor, but node doesn't have an API to achieve this. The only other node module that provides the
fcntl(2)binding doesn't play well with esbuild, so we need to recruit the help of our friend here.This change adds two functions to get/set the close-on-exec flag on a file descriptor.