Skip to content

Commit

Permalink
Drop support of Node.js 12. Update workflow files
Browse files Browse the repository at this point in the history
  • Loading branch information
AmsterGet committed Jul 31, 2024
1 parent dfffa3d commit 0f26b4d
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 15 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/CI-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12, 14, 16, 18, 20]
node: [14, 16, 18, 20, 22]
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand All @@ -50,8 +50,5 @@ jobs:
- name: Run lint
run: npm run lint

- name: Run tests
run: npm test

- name: Check coverage
- name: Run tests and check coverage
run: npm run test:coverage
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
- name: Install of node dependencies
run: npm install
- name: Run lint
Expand All @@ -45,7 +45,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
registry-url: 'https://registry.npmjs.org'
- name: Install of node dependencies
run: npm install
Expand All @@ -59,7 +59,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
registry-url: 'https://npm.pkg.github.com'
scope: '@reportportal'
- name: Publish to GPR
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
releaseVersion: ${{ steps.exposeVersion.outputs.releaseVersion }}
steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Read version
id: readVersion
run: |
Expand Down Expand Up @@ -78,9 +78,9 @@ jobs:
versionInfo: ${{ steps.readChangelogEntry.outputs.log_entry }}
steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup NodeJS
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '12'
- name: Configure git
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Create Release
id: createRelease
uses: actions/create-release@v1
Expand Down
9 changes: 7 additions & 2 deletions lib/report-portal-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,12 @@ class RPClient {

checkConnect() {
const url = [this.config.endpoint.replace('/v2', '/v1'), 'user'].join('/');
return RestClient.request('GET', url, {}, { headers: this.headers, ...this.restClient.getRestConfig()});
return RestClient.request(
'GET',
url,
{},
{ headers: this.headers, ...this.restClient.getRestConfig() },
);
}

async triggerStatisticsEvent() {
Expand Down Expand Up @@ -332,7 +337,7 @@ class RPClient {
'filter.in.uuid': launchUUIds,
'page.size': launchUUIds.length,
});
const launchSearchUrl = this.config.mode === 'DEBUG' ?
const launchSearchUrl = this.config.mode === 'DEBUG' ?
`launch/mode?${params.toString()}` : `launch?${params.toString()}`;
this.logDebug(`Find launches with UUIDs to merge: ${launchUUIds}`);
return this.restClient
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
],
"main": "./lib/report-portal-client",
"engines": {
"node": ">=12.x"
"node": ">=14.x"
},
"dependencies": {
"axios": "^1.6.8",
Expand Down

0 comments on commit 0f26b4d

Please sign in to comment.