EPMRPP-97027 user avatar #2111
EPMRPP-97027 user avatar #2111
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java
Outdated
Show resolved
Hide resolved
| import org.springframework.web.bind.annotation.ResponseStatus; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController |
There was a problem hiding this comment.
Missing a Javadoc comment.
| @PreAuthorize(IS_ADMIN) | ||
| @Operation(summary = "Exports information about all users", description = "Allowable only for users with administrator role") | ||
| public void export(@Parameter(schema = @Schema(allowableValues = "csv")) | ||
| @RequestParam(value = "view", required = false, defaultValue = "csv") String view, |
There was a problem hiding this comment.
'@' has incorrect indentation level 2, expected level should be 6.
| @PostMapping(value = "/{userId}/api-keys") | ||
| @ResponseStatus(CREATED) | ||
| @Operation(summary = "Create new Api Key for current user") | ||
| public ApiKeyRS createApiKey(@RequestBody @Validated ApiKeyRQ apiKeyRQ, |
There was a problem hiding this comment.
Abbreviation in name 'apiKeyRQ' must contain no more than '1' consecutive capital letters.
| @@ -44,6 +44,8 @@ private Permissions() { | |||
| public static final String ALLOWED_TO_VIEW_PROJECT = | |||
| "hasPermission(#projectKey.toLowerCase(), 'allowedToViewProject')" + "||" + IS_ADMIN; | |||
|
|
|||
| public static final String AUTHENTICATED = IS_ADMIN + "||" + "hasPermission(#userId, 'authenticated')"; | |||
There was a problem hiding this comment.
Line is longer than 100 characters (found 105).
| import org.springframework.security.core.Authentication; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Component("authenticatedUserPermission") |
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -34,6 +34,15 @@ public interface GetFileHandler { | |||
| */ | |||
| BinaryData getUserPhoto(ReportPortalUser loggedInUser, boolean loadThumbnail); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
First sentence of Javadoc is missing an ending period.
| import org.springframework.web.bind.annotation.ResponseStatus; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController |
There was a problem hiding this comment.
Do we need mark this controller as depricated?
There was a problem hiding this comment.
For now only 2 methods marked for removal
/v1/users/