-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2280] Specify time periods for different repos in csv config #2281
base: master
Are you sure you want to change the base?
Conversation
… into config-dates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the backend changes!
Left some minor nits regarding naming.
Also, I think tests for the changes in RepoConfiguration may be missing? Would be good to ascertain default values if hasUpdatedSinceDateInConfig
and hasUpdatedUntilDateInConfig
are false, and if the commits are filtered correctly according to the individual repo's date ranges.
Should update docs for the new fields too.
Just thought of another thing, is |
I will add additional steps to impose this constraint. |
Wait I was just asking if that is a constraint, not sure if it's supposed to be one. I was mainly wondering what would be the intended behavior if If allowed, will the commits in |
Sorry for the oversight. I think the commit.json will still follow the individual repo's sinceDate and untilDate. But currently the frontend may not display in the correct way. |
Alright gotcha, thanks! I'll make the frontend changes according to this then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may need to update the UG docs (docs/ug/configFiles.md
) as well.
But other than that, LGTM!
Fix #2280
Proposed commit message
Other information
Sample CSV
New format of
summary.json
Related issue: #2283