-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rewrite in TypeScript with CacheMap support #25
Conversation
d8b37a6
to
b8a90d3
Compare
4a43de2
to
b8ea280
Compare
Recovered the cache-source and cache-target options but with deprecation messages. Also, added an example of running this outside GitHub Actions. |
|
The error you sent doesn't happen on my fork. But I pushed a fix regardless for more robust error handling |
The test passes when some cache is present on GHA, but it still fails after pruning the cache via https://github.com/reproducible-containers/buildkit-cache-dance/actions/caches |
Also, please remove the "Merge" commit (use |
BREAKING `cache-source` and `cache-target` are removed in favour of `cache-map` that expects a JSON string Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Okay, found the bug. The stdout was not being captured properly. |
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Simplified and fixed the docker to tar data piping issue. It now works on my fork with cache pruned as well: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Thanks @aminya this is a really significant improvement! |
You're welcome! |
This pull request rewrites the action in TypeScript and adds support for
cache-map
that gets a string of files that need to be injected as a JSON string. This makes it possible to inject multiple directories in one call and simplifies the usage.It also makes it possible to run the script outside GitHub Actions (e.g. for S3) or locally using command line arguments.
BREAKING
cache-source
andcache-target
are deprecated in favour ofcache-map
that expects a JSON string.I have bumped the version to v3.0.0
Fixes #10
Closes #24
Closes #22
Allows implementation of #16