feat: support arbitrary mount options for each cache #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
support-cache-props
branch
2 times, most recently
from
4716303 to
57d2f8c
Compare
AkihiroSuda
reviewed
Apr 2, 2024
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
aminya
force-pushed
the
support-cache-props
branch
from
2ff6d18 to
cfc6f5e
Compare
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
aminya
force-pushed
the
support-cache-props
branch
from
d086e9f to
d2e9ac7
Compare
Signed-off-by: Amin Yahyaabadi <[email protected]>
aminya
force-pushed
the
support-cache-props
branch
from
4020c7e to
2a1e987
Compare
|
@AkihiroSuda Any more comment on this? |
|
Thanks @aminya for exposing all the mount arguments. As it turns out, I needed to set both the cash ID and sharing mode to match my Dockerfile in order for the cash injection and extraction to utilize the correct cash mount. Perhaps the sharing mode is included in the derivation of the internal cash key. Needless to PR now gives us that flexibility! |
|
You're welcome! It's cool to see another robotics engineer using these tools. I find the path parameter usually enough for my use cases, but feel free to document your findings in the readme. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Closes #21