Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not preserving uid and/or gid #35

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Fix not preserving uid and/or gid #35

merged 3 commits into from
Jun 10, 2024

Conversation

mabrikan
Copy link
Contributor

@mabrikan mabrikan commented Jun 4, 2024

Fixes #34 .

@AkihiroSuda
Copy link
Member

Thanks, dist/index.js needs to be regenerated

@mabrikan
Copy link
Contributor Author

Got it. Done ✅ .

mabrikan added 2 commits June 10, 2024 14:13
@mabrikan
Fix not preserving uid and/or gid
5ed2fde 
Signed-off-by: Musaed Albrikan <[email protected]>
@mabrikan
Add generated build files
f6f52a1 
Signed-off-by: Musaed Albrikan <[email protected]>
@mabrikan mabrikan force-pushed the fix-not-setting-uid-and-gid branch from 1b24a6c to f6f52a1 Compare June 10, 2024 11:13
@mabrikan
Copy link
Contributor Author

Last force commit is to add sign-off and make DCO happy :).

@mabrikan
Use pnpm instead of npm to build
3ef5261 
Signed-off-by: Musaed Albrikan <[email protected]>
@mabrikan mabrikan force-pushed the fix-not-setting-uid-and-gid branch from 11c7220 to 3ef5261 Compare June 10, 2024 12:08
AkihiroSuda
AkihiroSuda approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, next time please squash the commits

@AkihiroSuda AkihiroSuda merged commit 1e9b89a into reproducible-containers:main Jun 10, 2024
3 checks passed
@mabrikan mabrikan deleted the fix-not-setting-uid-and-gid branch June 10, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UID and GID are Not Preserved When Injecting Cache
2 participants
@mabrikan @AkihiroSuda