Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #30 upgrade parquet-go to 1.5.2 #31

Merged
merged 2 commits into from
May 11, 2020
Merged

Fix #30 upgrade parquet-go to 1.5.2 #31

merged 2 commits into from
May 11, 2020

Conversation

syucream
Copy link
Contributor

@syucream syucream commented May 10, 2020

It resolves #30 and #24, like below:

$ ./columnify -recordType jsonl -schemaType avro -schemaFile rails-log.avsc =(head -n 10 crash.json.log) > /dev/null
2020/05/11 00:36:43 Failed to write: reflect: call of reflect.Value.Type on zero Value
[ryo@Macintosh] $ echo $?
1

A error log is still not kind but mitigate the problem, but anyway doesn't panic!

As an other topic, unfortunately I found a possibility of data race in parquet-go library, so I removed -race from testing rule. ref. xitongsys/parquet-go#256

@syucream syucream requested a review from okkez May 10, 2020 15:41
@syucream syucream self-assigned this May 10, 2020
Copy link
Contributor

@okkez okkez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syucream syucream merged commit 5622bf2 into master May 11, 2020
@syucream syucream deleted the parquet-go-1.5.2 branch May 11, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic if provide a valid jsonl file
2 participants