detach only detachable instances #96
Merged
+89
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okkez
reviewed
Aug 7, 2024
Comment on lines
69
to
74
| instance_ids.each_slice(MAX_DETACHABLE_INSTANCE_COUNT) do |ids| | ||
| # detach only detachable instances | ||
| auto_scaling_group_instances = describe_detachable_instances | ||
| detachable_instance_ids = instance_ids.select do |instance_id| | ||
| auto_scaling_group_instances.any? { |instance| instance.instance_id == instance_id } | ||
| end |
There was a problem hiding this comment.
How about this code?
detachable_instance_ids = instance_ids & describe_detachable_instances.map(&:instance_id)
akihiro17
force-pushed
the
detach-only-detachable-instances
branch
from
dc7d04f to
e397ae7
Compare
okkez
approved these changes
Aug 7, 2024
YAMASHITAHiroki
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstanceDrainersometimes detaches instances that are not inInServiceorStandbyfor some reason.I believe
AutoScalingGroupConfig#detach_instancesshould only detach detachable instances becauseInstanceDrainercallsdetach_instancesdirectly when it receives instance interruption warnings.ref.
ecs_deploy/lib/ecs_deploy/auto_scaler/instance_drainer.rb
Line 107 in 1eae0ba
Additionally, I exclude pending instances from detachable instances because EC2 instances sometimes stay in the
Pendingstate for more than 10 minutes.Note
EcsDeploydetaches only detachable instances when it executesupdate_desired_capacity.ref.
ecs_deploy/lib/ecs_deploy/auto_scaler/auto_scaling_group_config.rb
Line 85 in 1eae0ba