Try updating to the new location and current version for root's acme #6141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #3459 (comment) when trying to set up SSL terminated directly by wiki.js on DigitalOcean, and I noticed it was running into trouble in some code in the
acme
module that has been changed for a bugfix since about the 3.0.3 we are using, but which hasn't been picked up because the module moved in NPM. It now lives in@root
with a bunch of the other related modules, and the current version is 3.1.0.This is an attempt to move to that version of the module, to maybe resolve my weird LetsEncrypt issues. If this doesn't pass tests, there are other 3.0.x patch releases under
@root
we could try.I'm not sure this will really fix the bug though; the commit I think I need:
therootcompany/acme.js@0aa939a
is only in 3.1.1, not 3.1.0. And 3.1.1 is released on Github but never got published in NPM; see therootcompany/acme.js#4
Nonetheless, I don't think it makes sense to keep using the old module name.
I tried to
npm install
to get any lockfiles to update, but it did not appear to make any changes to tracked files. I also tried tonpm run test
to make sure this actually works, and I got a bunch of error-level messages from the linter that had nothing to do with my change, like:I think I'm not setting up the project for development in the same way as other contributors are, but there's nothing in the README or contributing file that suggests that I should be doing anything different. So hopefully CI can test this and no lockfile changes are needed.