Migrate file format to protobuf #8995
Open
+113
−565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jprochazk
added
the
🪵 Log & send APIs
jprochazk
force-pushed
the
jan/migrate-file-protobuf
branch
from
b1ebf6e to
cb6f4f8
Compare
jprochazk
force-pushed
the
jan/migrate-file-protobuf
branch
from
cb6f4f8 to
ea90dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
rrdto protobuf #8993MsgPackserializer #8994What
protobufencoding for our file format.msgpackcode from the repository.Tested by opening running the
clockexample and attempting to load the data in both the native and web viewers.There are still some pieces left in the file format that have now been made redundant. One example is the per-recording
compressionfield. We don't use that anymore, compression is now specified perArrowMsg. There are a few other things like that, but I believe that refactoring is better left to the time when we decide to get rid ofLogMsg, which would be another breaking change for the file format.