Improve Tuid
#8999
Merged
Improve Tuid
#8999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🚜 refactor
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
force-pushed
the
emilk/tuid-improvements
branch
from
bb32ec0 to
f806716
Compare
emilk
force-pushed
the
emilk/tuid-improvements
branch
from
f806716 to
83ee7c6
Compare
teh-cmc
approved these changes
Feb 12, 2025
Comment on lines
+299
to
+301
| fn test_tuid_size_and_alignment() { | ||
| assert_eq!(std::mem::size_of::<Tuid>(), 16); | ||
| assert_eq!(std::mem::align_of::<Tuid>(), 1); |
There was a problem hiding this comment.
Can we use static_assertions for these things these days?
There was a problem hiding this comment.
We can, but it adds a dependency for no gain?
There was a problem hiding this comment.
It makes the type self-documenting in ways that comments or freestanding tests never will, and static_assertions is already an indirect dep of re_tuid.
| /// The format uses upper case for the first 16 hex digits, and lower case for the last 16 hex digits. | ||
| /// This is to make it easily distinguished from other hex strings. | ||
| /// | ||
| /// Example: `182342300C5F8C327a7b4a6e5a379ac4` |
There was a problem hiding this comment.
Eeeeeeeh, this part I'm really not a fan tbh, but okay 🤷
Co-authored-by: Clement Rey <[email protected]>
Merged
jprochazk
pushed a commit
that referenced
this pull request
Feb 13, 2025
### Related * Part of #8992 ### What Improve `re_tuid::Tuid`, and by extension `RowId` and `ChunkId` (which are just typesafe wrappers around `Tuid`) ### Details * Implement `from_str` for `Tuid/RowId/ChunkId` * Slightly modify how Tuid is formatted as a string (in backwards/forwards compatible way!)] * Implement bytemucking * Align to bytes (see below) ### Change `Tuid` alignment from `8` to `1` This will allow us to cast raw bytes into a `&[RowId]`. `arrow-rs` already aligns all allocations to 64 bytes, so _theoretically_ there would be nothing to stop us from already doing this, but this is the "better safe than sorry" approach. `uuid:::Uuuid` is also aligned to bytes, FWIW. * `Tuid::new` becomes ~7% slower * `Tuid::cmp` is unaffected --------- Co-authored-by: Clement Rey <[email protected]>
jprochazk
pushed a commit
that referenced
this pull request
Feb 13, 2025
### Related * Part of #8992 ### What Improve `re_tuid::Tuid`, and by extension `RowId` and `ChunkId` (which are just typesafe wrappers around `Tuid`) ### Details * Implement `from_str` for `Tuid/RowId/ChunkId` * Slightly modify how Tuid is formatted as a string (in backwards/forwards compatible way!)] * Implement bytemucking * Align to bytes (see below) ### Change `Tuid` alignment from `8` to `1` This will allow us to cast raw bytes into a `&[RowId]`. `arrow-rs` already aligns all allocations to 64 bytes, so _theoretically_ there would be nothing to stop us from already doing this, but this is the "better safe than sorry" approach. `uuid:::Uuuid` is also aligned to bytes, FWIW. * `Tuid::new` becomes ~7% slower * `Tuid::cmp` is unaffected --------- Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Improve
re_tuid::Tuid, and by extensionRowIdandChunkId(which are just typesafe wrappers aroundTuid)Details
from_strforTuid/RowId/ChunkIdChange
Tuidalignment from8to1This will allow us to cast raw bytes into a
&[RowId].arrow-rsalready aligns all allocations to 64 bytes, so theoretically there would be nothing to stop us from already doing this, but this is the "better safe than sorry" approach.uuid:::Uuuidis also aligned to bytes, FWIW.Tuid::newbecomes ~7% slowerTuid::cmpis unaffected