gRPC spec update: Add support for fetching temporal range of recordings #9010
Conversation
zehiko
added
exclude from changelog
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
| @@ -12,6 +12,9 @@ service StorageNode { | |||
| rpc CreateIndex(CreateIndexRequest) returns (CreateIndexResponse) {} | |||
| rpc ReIndex(ReIndexRequest) returns (ReIndexResponse) {} | |||
|
|
|||
| rpc GetChunkIds(GetChunkIdsRequest) returns (stream GetChunkIdsResponse) {} | |||
| rpc GetChunks(GetChunksRequest) returns (stream rerun.common.v0.RerunChunk) {} | |||
There was a problem hiding this comment.
This is typically not advised, and I've personally made the mistake of re-using return types before I learned of this advice.
There was a problem hiding this comment.
I think there's a topic here, this already came up. Right now we re-use DataframePart and RerunChunk across more than a few calls, which was intentional and done as part of https://github.com/rerun-io/dataplatform/issues/74.
For now I'd keep it, but let's discuss this re-use and get rid or keep all of them, if that makes sense.
There was a problem hiding this comment.
There was a problem hiding this comment.
Adding pagination support for GetChunks might be a case in point. A typical GetChunksResponse message would include a RerunChunk, and also possibly a breadcrumb to the next page, or even stats.
Temporary consistency for now sounds good though.
…gs (#9010) ### What Adding support for fetching chunks that belong to specific range of the recording. This consists of the 2 APIs calls: * fetching chunk ids for a given range * fetching chunks for the given chunk ids (which we might want to leverage separately in the future) As there is a limitation for the client side gRPC streaming on the web (see [here](#8877 (comment))), we've decided to send a batch of chunk ids to the server. To make the APIs somewhat symmetrical, the 1st API call will stream batches of chunk ids. Closes * #8877
What
Adding support for fetching chunks that belong to specific range of the recording. This consists of the 2 APIs calls:
As there is a limitation for the client side gRPC streaming on the web (see here), we've decided to send a batch of chunk ids to the server. To make the APIs somewhat symmetrical, the 1st API call will stream batches of chunk ids.
Closes