Encode wether or not a chunk is sorted by RowId in the column metadata
#9041
+56
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Part of #8744 It used to be encoded in the `RecrodBatch` metadata. It makes more sense to encode it on the column metadata though, and brings the RowId column closer to the time columns (I hope to unify the two in the near future).
emilk
added
exclude from changelog
emilk
force-pushed
the
emilk/encode-row-id-sort-in-column-metadata
branch
from
fb6eaf3 to
535d8c2
Compare
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re_sorbetChunk/Dataframe conversion crate handle arrow metadata #8744It used to be encoded in the
RecordBatchmetadata. It makes more sense to encode it on the column metadata though, and brings theRowIdcolumn closer to the time columns (I hope to unify the two in the near future).