Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct BatchType in re_sorbet #9052

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Use correct BatchType in re_sorbet #9052

merged 3 commits into from
Feb 17, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 17, 2025

Trying to unblock the DP, but I literally have no idea what I'm doing here.

Copy link

github-actions bot commented Feb 17, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
08c37f0 https://rerun.io/viewer/pr/9052 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc marked this pull request as ready for review February 17, 2025 11:40
@emilk emilk self-requested a review February 17, 2025 14:23
@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🔩 data model Sorbet labels Feb 17, 2025
@emilk emilk changed the title Re-expose BatchType when converting sorbet columns to arrow fields Use correct BatchType in re_sorbet Feb 17, 2025
@emilk emilk added the 🪳 bug Something isn't working label Feb 17, 2025
@emilk emilk merged commit 79a1003 into main Feb 17, 2025
39 of 40 checks passed
@emilk emilk deleted the cmc/reexpose_batch_type branch February 17, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🔩 data model Sorbet exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants