Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transposed RecordBatch formatter and other niceties #9056

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 17, 2025

No description provided.

@teh-cmc teh-cmc added enhancement New feature or request 🏹 arrow concerning arrow include in changelog labels Feb 17, 2025
@teh-cmc teh-cmc mentioned this pull request Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
23c7936 https://rerun.io/viewer/pr/9056 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc added the 🦀 Rust API Rust logging API label Feb 17, 2025
@emilk emilk self-requested a review February 17, 2025 14:49
@emilk emilk added the 🧑‍💻 dev experience developer experience (excluding CI) label Feb 17, 2025
pub width: Option<usize>,

/// If `true`, displays the dataframe's metadata too.
pub include_metadata: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default of this changed to false - was this intentional? Does cargo test -p re_format_arrow still pass?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything still pass, the PR is green :) The old codepaths still default to true.

@emilk emilk merged commit d4e1481 into main Feb 17, 2025
35 checks passed
@emilk emilk deleted the cmc/transposed_formatter branch February 17, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow 🧑‍💻 dev experience developer experience (excluding CI) enhancement New feature or request include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants