Improve comment regarding arrow1-IPC-serialization #9057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🪳 bug
|
Web viewer failed to build.
Note: This comment is updated whenever you push a commit. |
|
Well, look that this cannot be enabled after all :/ |
teh-cmc
changed the title
|
Guess I'll keep it disabled and update the comment. |
emilk
changed the title
emilk
approved these changes
Feb 17, 2025
teh-cmc
force-pushed
the
cmc/arrow1_please
branch
from
ddc00b1 to
cd2c198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrow2 serializer drops half of the metadata in the process, which is making it hard to work on manifests...
As far as I know there is no problem with enabling arrow1 on this path (and I can confirm that it fixes my metadata issues).