Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default handling of URIs without an endpoint #9063

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Feb 17, 2025

What

Previously, rerun://localhost:51234 and rerun://localhost:51234/ didn't forward to catalog/ because of an error in the parsing logic.

Added test cases.

Copy link

github-actions bot commented Feb 17, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
6e17fed https://rerun.io/viewer/pr/9063 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Feb 17, 2025
@emilk emilk merged commit 044b783 into main Feb 18, 2025
35 checks passed
@emilk emilk deleted the grtlr/fix-default-uri-parsing branch February 18, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants