Build Rust snippets first then run them in parallel as a separate step #9093
+66
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🔨 testing
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13434129701 |
Wumpf
commented
Feb 20, 2025
This should avoid race conditions we're seeing for instance here https://github.com/rerun-io/rerun/actions/runs/13427212000/job/37513736608 and might be overall faster Also, we still didn't run C++ tests in parallel despite already factoring out the build (running CMake in parallel is known to be racy)
Wumpf
force-pushed
the
andreas/fix-snippet-comparision-linker-race
branch
from
d350535 to
6ad415d
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13435511145 |
emilk
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid race conditions we're seeing for instance here https://github.com/rerun-io/rerun/actions/runs/13427212000/job/37513736608 and might be overall faster Also, we still didn't run C++ tests in parallel despite already factoring out the build (running CMake in parallel is known to be racy)