-
Notifications
You must be signed in to change notification settings - Fork 465
[WIP] Editor mode #7369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] Editor mode #7369
Conversation
Hi @zth, I tried to play with this locally, but I can't get the library to build: Is this working for you? |
Seeing the same locally. I had this previously, but can't remember what it was. Will try and have a look soon. |
8204d40
to
cdbed51
Compare
import { spawn, spawnSync } from "node:child_process"; | ||
|
||
// Get the current ReScript version | ||
const rescriptVersion = spawnSync("./node_modules/.bin/bsc", ["-v"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but we probably have a better way to detect the bsc.exe
.
Using cli/bin_path.js
. @cometkim probably knows what to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { bsc } from "#dev/process";
const { stdout: version } = await bsc(["-v"]);
should work.
@@ -0,0 +1,7 @@ | |||
exports[`RecordFieldCompletions.res - Record field completion in nested record 1`] = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't focus on this, but this really is an unreadable snapshot file.
"dir": "support_files" | ||
}, | ||
{ | ||
"dir": "test_files/.build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is the extra content from this .build
folder?
…errors to produce more type information
* Use Vitest to have individual snapshot files * Show completable item in code fence * Update existing tests
* Inital dump of cmt * Dump locItems * Improve locTypeToString * Filter by cursor
b1518ea
to
b11f460
Compare
No description provided.