Skip to content

Add pkg.pr.new workflow #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 1, 2025
Merged

Add pkg.pr.new workflow #7412

merged 9 commits into from
May 1, 2025

Conversation

cometkim
Copy link
Member

No description provided.

Copy link

pkg-pr-new bot commented Apr 30, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7412

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7412

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7412

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7412

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7412

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7412

commit: 4eb3bc0

@cometkim
Copy link
Member Author

This works quite well. We can now remove the redundant npm-packages from the artifacts store.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! 👍

Co-authored-by: Christoph Knittel <[email protected]>
@cometkim cometkim merged commit 9a8f133 into master May 1, 2025
21 checks passed
@cometkim cometkim deleted the pkg-pr-new branch May 1, 2025 08:31
@nojaf
Copy link
Collaborator

nojaf commented May 1, 2025

This isn't quite working for me, repro

 npx rescript
file:///home/projects/hacbwtvt--run/node_modules/rescript/cli/rescript.js:12
import { bsc_exe, rescript_exe } from "./common/bins.js";
         ^^^^^^^

file:///home/projects/hacbwtvt--run/node_modules/rescript/cli/rescript.js:12
import { bsc_exe, rescript_exe } from "./common/bins.js";
         ^^^^^^^
SyntaxError: The requested module './common/bins.js' does not provide an export named 'bsc_exe'
    at ModuleJob._instantiate (https://hacbwtvtrun-lvo5.w-credentialless-staticblitz.com/builtins.97a3df4f.js:158:2290)
    at async ModuleJob.run (https://hacbwtvtrun-lvo5.w-credentialless-staticblitz.com/builtins.97a3df4f.js:158:3320)
    at async ModuleLoader.import (https://hacbwtvtrun-lvo5.w-credentialless-staticblitz.com/builtins.97a3df4f.js:157:5061)
    at async asyncRunEntryPointWithESMLoader (https://hacbwtvtrun-lvo5.w-credentialless-staticblitz.com/builtins.97a3df4f.js:168:797) {
  [Symbol(node:decorated)]: true
}

Node.js v20.19.1

Locally on my Mac I had:

nojaf@nojaf-mbp ronnies.be % bunx rescript
>>>> Start compiling
Dependency on @rescript/webapi
rescript: [1/311] WebAPI.cmi
FAILED: WebAPI.cmi

  We've found a bug for you!
  command line

  The module or file Pervasives can't be found.
  - If it's a third-party dependency:
    - Did you add it to the "bs-dependencies" or "bs-dev-dependencies" in bsconfig.json?
  - Did you include the file's directory to the "sources" in bsconfig.json?
  

FAILED: cannot make progress due to previous errors.
Failure: /Users/nojaf/Projects/xyz/node_modules/rescript/node_modules/@rescript/darwin-arm64/bin/ninja.exe 
Location: /Users/nojaf/Projects/xyz/node_modules/@rescript/webapi/lib/bs
>>>> Finish compiling (exit: 1)

@cometkim
Copy link
Member Author

cometkim commented May 1, 2025

The reported issue is not related to pkg.pr.new. It needs to be investigated why re-export is not working in StackBlitz.

And the Pervasives issue is related to the standard-library seeking mechanism, maybe there is no matched node_modules structure? @nojaf could you check it with bun why rescript in your project?

@nojaf
Copy link
Collaborator

nojaf commented May 1, 2025

Hmm, after trying it again, I didn't have that issue on Mac.
Might be some invalid state issue on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants