-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRestDataSetPlot improvements #520
Conversation
…pression containing any of the previous key values
Getting rid of the keys variable, metadata and observable would simplify a lot the code as it would get rid of the following duplicated code lines: framework/source/framework/core/src/TRestDataSetPlot.cxx Lines 353 to 391 in d31c89d
framework/source/framework/core/src/TRestDataSetPlot.cxx Lines 589 to 634 in d31c89d
But they are needed in TRestDataSetPlot::GenerateDataSetFromFilePattern(). A possible workaround could be to use the double [[]] encapsualting variable keywords ( e.g. [[entries]] ), the single [] encapsulating metadata (e.g. [TRestDetector::fPressure]) and naked observable names (e.g. rawAna_ThresholdIntegral) to identify them inside that method. |
…aSetFromFilePattern and PrintMetadata methods)
* origin/master: TRestDataSetPlot improvements (#520)
Extended the scale option to use any mathematical expression in combination with the special keywords.
New keywords:
Add cuts, cutNames, panelCut and panelCutNames to paramMap to be able to show them in the panel (in the same way as meanRate for example). Also add RESTinfo message to output the global and additional panel cuts applied.
EnableMultiThreading when handling the TRestDataSet (avoids annoying "Warning in <ROOT_TImplicitMT_DisableImplicitMT>: Implicit multi-threading is already disabled" message)
Added new key expression in panel definition to parse a mathematical expression that can contain any of the previous key values (variable, metadata and observable). It is a generalization of these previous keys, so this new expression key could replace them for good but I keep them for retrocompatibility.