Fix TRestRawFeminosRootToSignalProcess setting a wrong timestamp #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvaroEzq
changed the title
JPorron
approved these changes
Jan 16, 2025
mariajmz
approved these changes
Jan 16, 2025
AlvaroEzq
force-pushed
the
alvaroezq_fixRootToSignal
branch
from
af4a600 to
b318279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix issue #149
The timestamp of the event is not set correctly in this line:
rawlib/src/TRestRawFeminosRootToSignalProcess.cxx
Lines 126 to 127 in a4ba0c1
This is due to the fInputEventTreeTimestamp being in milliseconds and the method TRestEvent::SetTime second parameter is nanoseconds. So the subsecond information of the timestamp is not correct. This is solved easily by just changing that line to
fSignalEvent->SetTime(fInputEventTreeTimestamp / 1000, fInputEventTreeTimestamp % 1000 * 1.e6);