Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cron): add support for day-of-month special characters #151

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

reugn
Copy link
Owner

@reugn reugn commented Feb 2, 2025

Implement support for L (last day) and W (weekday) special characters in the cron day-of-month field.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.44%. Comparing base (f817e56) to head (9d050dc).

Files with missing lines Patch % Lines
quartz/cron.go 78.57% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   94.83%   94.44%   -0.40%     
==========================================
  Files          19       19              
  Lines        1182     1207      +25     
==========================================
+ Hits         1121     1140      +19     
- Misses         45       49       +4     
- Partials       16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reugn reugn merged commit 21cefa7 into master Feb 2, 2025
5 checks passed
@reugn reugn deleted the cron-day-of-month-characters branch February 2, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants