Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation fixes #361

Merged
merged 4 commits into from
Jun 22, 2020

Conversation

vlumi
Copy link
Contributor

@vlumi vlumi commented Jun 5, 2020

Hi @reustle

Adding the missing Spanish translation for #359, and removing the couple obsolete entries that were moved under another key (#351).

… and unspecified that already exist under pseudo-prefectures.
@vlumi vlumi changed the title Add Spanish translation for top-prefectures, and remove port-of-entry… Spanish translation fixes Jun 5, 2020
Copy link
Contributor

@alangazzano alangazzano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

44 "active-critical-percentage": "{{percent}}% están en condición crítica.",

Copy link
Contributor

@alangazzano alangazzano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 "prefecture-data": "Datos por Prefectura",

@vlumi
Copy link
Contributor Author

vlumi commented Jun 22, 2020

The changes have been made to this pull request, but one of the maintainers would first need to merge and release it before the changes appear on the site.

Meanwhile, if you have interest, there are some other missing Spanish translations listed in #351 which could be included here as well...

@alangazzano
Copy link
Contributor

The changes have been made to this pull request, but one of the maintainers would first need to merge and release it before the changes appear on the site.

Meanwhile, if you have interest, there are some other missing Spanish translations listed in #351 which could be included here as well...

Sorry, I can't see them. Would you please tell me how to see the sentences to be translated?

@vlumi
Copy link
Contributor Author

vlumi commented Jun 22, 2020

Sorry, I can't see them. Would you please tell me how to see the sentences to be translated?

The following are missing for Spanish:

  • "languages" ("Languages" In language selector)
  • "increment-today" ("Today" in Top 10 Prefectures)
  • "increment-yesterday" ("Yesterday" in Top 10 Prefectures)
  • "daily" ("Daily" in the legend for Nuevos casos diarios)
  • "7-day-average" ("7-day average" in the legend for Nuevos casos diarios)

@reustle
Copy link
Owner

reustle commented Jun 22, 2020

Thanks! Once these final changes are made, I'll merge it in.

@alangazzano
Copy link
Contributor

Thanks. These are the Spanish translations:

* "languages" ("Idiomas" In language selector)

* "increment-today" ("Hoy" in Top 10 Prefectures)

* "increment-yesterday" ("Ayer" in Top 10 Prefectures)

* "daily" ("Diarios" in the legend for Nuevos casos diarios)

* "7-day-average" ("Media semanal" in the legend for Nuevos casos diarios)

@vlumi
Copy link
Contributor Author

vlumi commented Jun 22, 2020

All updated.

@reustle reustle merged commit 65c8cf7 into reustle:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants