Skip to content

Bump Eclipse version and require Maven 3.9.0 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Bump Eclipse version and require Maven 3.9.0 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
Bundle-Name: Eclipse JSDT core
Bundle-SymbolicName: jsdt-core
Bundle-Vendor: Revelc
Bundle-Version: 3.4.5.qualifier
Bundle-Version: 3.5.0.qualifier
Require-Bundle: org.eclipse.wst.jsdt.core;bundle-version="[1.0.0,10.0.0)"
Bundle-RequiredExecutionEnvironment: JavaSE-17
Automatic-Module-Name: org.eclipse.wst.jsdt.core
5 changes: 3 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</parent>
<groupId>net.revelc.code.formatter</groupId>
<artifactId>jsdt-core</artifactId>
<version>3.4.5-SNAPSHOT</version>
<version>3.5.0-SNAPSHOT</version>
<packaging>eclipse-plugin</packaging>
<name>Eclipse JSDT Core Bundle</name>
<description>Repackaging of Eclipse JSDT bundled for Maven Central</description>
Expand Down Expand Up @@ -46,7 +46,7 @@
<url>https://github.com/revelc/jsdt-core</url>
</scm>
<properties>
<eclipse-repo.url>https://download.eclipse.org/releases/2024-03</eclipse-repo.url>
<eclipse-repo.url>https://download.eclipse.org/releases/2024-06</eclipse-repo.url>
<licenseText><![CDATA[
This program and the accompanying materials are made
available under the terms of the Eclipse Public License 2.0
Expand All @@ -60,6 +60,7 @@ SPDX-License-Identifier: EPL-2.0
<mdep.analyze.skip>true</mdep.analyze.skip>
<!-- rat plugin is no good at validating EPL headers out of the box -->
<rat.skip>true</rat.skip>
<revelc.min-build-mvn>3.9.0</revelc.min-build-mvn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just require 3.9.8? 3.9.0 is pretty buggy, so was the first few. 3.9.8 is best stable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the minimum. We can recommend newer. This minimum was derived automatically from the plugins configured in the pom.xml... they require at least 3.9.0.

<tychoVersion>4.0.8</tychoVersion>
</properties>
<repositories>
Expand Down