Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation with FPC + Lazarus of campaigns sorting algorithm #198

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dpronin
Copy link

@dpronin dpronin commented Jan 8, 2024

FPC and Lazarus on Linux do not have List.List[] property, but List fortunately has Sort() method at Linux platform with a comparator to give from a call site

Please, consider these changes to merge them in. The previous business logic of Windows's implementation has been preserved

@dpronin dpronin force-pushed the KM_Campaigns/sorting-algorithm-update branch 2 times, most recently from ea70219 to eb4a61d Compare January 8, 2024 09:23
@dpronin
Copy link
Author

dpronin commented Jan 8, 2024

I think these changes are easy to verify. We need to get list of current campaigns in the game and see that they are sorted according to the rules. Then we could create a dummy campaign, if it is possible, with the smallest efforts undertaken and name them with TSK, TPR and different other names and see that they are again sorted. Or, if it is possible and there is a list of such campaigns in resources, we might create dummy files and see that their names are sorted according to the rules

@reyandme
Copy link
Owner

reyandme commented Jan 8, 2024

Yes, this or similar test should be done.
Could you do such a test please ?
I would be able to do it, but some time later.

@dpronin
Copy link
Author

dpronin commented Jan 8, 2024

Actually, I don't have Windows, neither installed nor an installer to install

@sado1
Copy link

sado1 commented Jan 9, 2024

as in the other MR, I could test those changes eventually
it seems like a low risk change

@dpronin
Copy link
Author

dpronin commented Jan 9, 2024

as in the other MR, I could test those changes eventually it seems like a low risk change

I would appreciate if you did

@dpronin dpronin force-pushed the KM_Campaigns/sorting-algorithm-update branch 3 times, most recently from 8c963a1 to 782014e Compare January 10, 2024 00:19
@dpronin dpronin force-pushed the KM_Campaigns/sorting-algorithm-update branch from 782014e to 009a0cc Compare July 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants