Address reviewer feedback

rfbgo · Nov 15, 2024 · b4e4730 · b4e4730
1 parent 0c2fbf9
commit b4e4730
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/lib/ramble/docs/results.rst b/lib/ramble/docs/results.rst
@@ -47,10 +47,6 @@ Multiple plot types are supported, to aid in comparison of runs and common tasks
 For these plots, common operations are supported such as log axis, data
 grouping, and idealized line plotting.
 
-While this functionality is very useful and powerful, it is not intended as a
-wholesale replacement for uploading the data into more advanced offline
-analysis tools.
-
 ^^^^^^^^^^^^^^^
 Strong and Weak Scaling Plots
 ^^^^^^^^^^^^^^^

diff --git a/lib/ramble/ramble/test/reports.py b/lib/ramble/ramble/test/reports.py
@@ -217,13 +217,12 @@ def test_scaling_plots(mutable_mock_workspace_path, tmpdir_factory, values):
     logy = False
     split_by = "simplified_workload_namespace"
 
+    where_query = None
+    results_df = prepare_data(results, where_query)
+    plot = plot_type(test_spec, normalize, report_dir_path, results_df, logx, logy, split_by)
+
     with PdfPages(pdf_path) as pdf_report:
-        where_query = None
-        results_df = prepare_data(results, where_query)
-        plot = plot_type(
-            test_spec, normalize, report_dir_path, pdf_report, results_df, logx, logy, split_by
-        )
-        plot.generate_plot_data()
+        plot.generate_plot_data(pdf_report)
 
         # Sort columns alphabetically, order is not important
         plot.output_df.sort_index(axis=1, inplace=True)