Add fillCoreSpectraVariables utility function and report number of matching peaks with compareSpectra #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a `fillCoreSpectraVariables()` function that allows to fill a spectra data frame with eventually missing core spectra variables (with the correct data type). This function will be particularly helpful for newly implemented `MsBackend` classes.
- Add parameter `matchedPeaksCount` to `compareSpectra()` to allow reporting of the number of matching peaks between the compared spectra (issue #350).
jorainer
changed the title
philouail
reviewed
Feb 20, 2025
|
|
||
| #' The number of matching peaks: | ||
| sim[, , 2L] | ||
| ``` |
There was a problem hiding this comment.
Maybe it's unnecessary, but maybe you could add a small example of filtering based on the number of matching peaks.
There was a problem hiding this comment.
hm, yes, thanks. I will add that later.
philouail
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two things:
fillCoreSpectraVariables()function that fills a spectra data frame with eventually missing core spectra variables (with the correct data type). This function will be particularly helpful for newly implementedMsBackendclasses.matchedPeaksCountparameter tocompareSpectra()to allow reporting of the number of matching peaks between compared spectra (see issue compareSpectra to report also the number of matching peaks #350 for details).