Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy: make test tasks depend on build tasks #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucascolley
Copy link
Contributor

@lucascolley lucascolley commented Dec 30, 2024

this ensures that, if one runs a test task before running the build task, the build is performed with the desired flags and env.

If a dev wants to perform a custom build before running a test task, they can run the test task with --skip-deps.

@lucascolley lucascolley changed the title scipy: make test tasks depend on build scipy: make test tasks depend on build tasks Dec 31, 2024
@rgommers
Copy link
Owner

rgommers commented Jan 2, 2025

Thanks Lucas. There was a reason why I didn't put this in earlier, and I can no longer remember the details - it had something to do with dependencies not being consistent across environments, or having to build in the default environment rather than the active non-default one.

I don't know if those reasons are still relevant. I'll try testing this.

@rgommers
Copy link
Owner

rgommers commented Jan 2, 2025

Is the multi-line syntax preferred? That one cannot line break the { } syntax is annoying, but I'm not sure the separate lines read better overall.

@lucascolley
Copy link
Contributor Author

Is the multi-line syntax preferred? That one cannot line break the { } syntax is annoying

preferred for me! Mainly because one cannot line break the { }.

@stefanv
Copy link
Contributor

stefanv commented Feb 5, 2025

Multi-line syntax should be available in TOML 1.1, scheduled for April 2024 🙃

toml-lang/toml#928
toml-lang/toml#928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants