Adds Dexnav #4818
Adds Dexnav #4818
Conversation
This makes so the msgbox doesn't move in the Y coordinate if the map popup was previously playing.
Msgbox fixes
…tatic asserts that flags, vars are setup and dexnav cannot be used/accessed otherwise
| @@ -200,6 +204,7 @@ static const struct MenuAction sStartMenuItems[] = | |||
| [MENU_ACTION_RETIRE_FRONTIER] = {gText_MenuRetire, {.u8_void = StartMenuBattlePyramidRetireCallback}}, | |||
| [MENU_ACTION_PYRAMID_BAG] = {gText_MenuBag, {.u8_void = StartMenuBattlePyramidBagCallback}}, | |||
| [MENU_ACTION_DEBUG] = {sText_MenuDebug, {.u8_void = StartMenuDebugCallback}}, | |||
| [MENU_ACTION_DEXNAV] = {gText_MenuDexNav, {.u8_void = StartMenuDexNavCallback}}, | |||
There was a problem hiding this comment.
FLAG_SYS_DEXNAV_GET needs to be set for it to show up so it does not overflow by default. I will add a comment about that here. The code needs to exist as a reference for the entry point of the GUI, also
|
Should have all reviews handled now |
include/config/dexnav.h
Outdated
| #define FLAG_SYS_DEXNAV_SEARCH 0 // Searching for mon | ||
| #define FLAG_SYS_DEXNAV_GET 0 // Dexnav shows in start menu | ||
| #define FLAG_SYS_DETECTOR_MODE 0 // Allow player to find hidden mons | ||
| #define VAR_DEXNAV_SPECIES 0 // Registered dexnav species | ||
| #define VAR_DEXNAV_STEP_COUNTER 0 // Steps for finding hidden pokemon |
There was a problem hiding this comment.
Final request before we merge this in: these five are all needed if DexNav is enabled, which means we should probably add a static assert to make sure these are set before people complain about UB related to exactly this. Thoughts?
There was a problem hiding this comment.
Already done. Those exist at the top of dexnav.c except FLAG_SYS_DEXNAV_GET since adding it to the start menu is not required for the implementation
ready for review
Merges in my dexnav branch with some rhh specific tweaks.
Everything is more or less kept the same