FakeRtc datetime and ResetRtcScreen day increments

[cawtds]

Description

Adds date extraction to FakeRtc_GetRawInfo. FakeRtc currently discards any date information.
Also added different day increments to ResetRtcScreen.

Discord contact info

.cawt

[AlexOn1ine]

@pkmnsnfrn do you think you could review this?

[pkmnsnfrn]

I intend to review this, but I sent this to cawt and my concern stands:

I skipped over date because nothing in vanilla Emerald uses date and I wanted to make sure my testing was accurate
I think its fine to include and I would like to include it, but I'm unsure as to how to test it since nothing uses date

[AlexOn1ine]

I intend to review this, but I sent this to cawt and my concern stands:

I skipped over date because nothing in vanilla Emerald uses date and I wanted to make sure my testing was accurate
I think its fine to include and I would like to include it, but I'm unsure as to how to test it since nothing uses date

2 Options:

1. Trust cawt if the code makes sense
2. Make a script for a trainer that can only be challenged on a specific date and use the mGBA Game Pak Sensor to manipulate the date

[pkmnsnfrn]

Nothing in testing revealed any issues
I would like to do a future PR that makes more of this data readily accessible via scripts like date and day of week but that's not needed right now!

[pkmnsnfrn]

Suggested change

	static void FakeRtc_AdvanceSeconds(struct SiiRtcInfo *rtc, u32 *days, u32*hours, u32 *minutes, u32 *seconds)
	{
	*seconds += rtc->second;
	*minutes += rtc->minute;
	*hours += rtc->hour;
	while (*seconds >= SECONDS_PER_MINUTE)
	{
	*minutes++;
	*seconds -= SECONDS_PER_MINUTE;
	}
	while (*minutes >= MINUTES_PER_HOUR)
	{
	*hours++;
	*minutes -= MINUTES_PER_HOUR;
	}
	while (*hours >= HOURS_PER_DAY)
	{
	*days++;
	*hours -= HOURS_PER_DAY;
	}
	rtc->second = *seconds;
	rtc->minute = *minutes;
	rtc->hour = *hours;
	}
	static void FakeRtc_SetDayOfWeek(struct SiiRtcInfo *rtc, u32 daysToAdd)
	{
	rtc->dayOfWeek = (rtc->dayOfWeek + daysToAdd) % WEEKDAY_COUNT;
	}
	static void FakeRtc_AdvanceDays(struct SiiRtcInfo *rtc, u32 *days)
	{
	u32 remainingDaysInMonth = (sNumDaysInMonths[rtc->month - 1] + (rtc->month == MONTH_FEB && IsLeapYear(rtc->year)) - rtc->day);
	if (*days > remainingDaysInMonth)
	{
	rtc->day = 1;
	rtc->month++;
	if (rtc->month > MONTH_DEC)
	{
	rtc->month = MONTH_JAN;
	rtc->year++;
	}
	*days -= (remainingDaysInMonth + 1);
	FakeRtc_SetDayOfWeek(rtc, remainingDaysInMonth + 1);
	}
	else
	{
	rtc->day += *days;
	FakeRtc_SetDayOfWeek(rtc, *days);
	*days = 0;
	}
	}

[pkmnsnfrn]

Github is being stupid but I'm trying to leave a suggestion to replace this function with

void FakeRtc_AdvanceTimeBy(u32 days, u32 hours, u32 minutes, u32 seconds)
{
    struct SiiRtcInfo *rtc = FakeRtc_GetCurrentTime();
    FakeRtc_AdvanceSeconds(rtc, &days, &hours, &minutes, &seconds);

    while (days > 0)
        FakeRtc_AdvanceDays(rtc, &days);
}