Field effect for cutting grass is missing setfieldeffectargument. Issue #5766 #5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedara90
reviewed
Jan 5, 2025
Co-authored-by: hedara90 <[email protected]>
hedara90
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
The field effect for cutting grass is not behaving consistently. This is due to the gFieldEffectArguments[3] not getting set properly, which is then checked in Task_DoFieldMove_Init. The other field moves have an associated script that does
but as the field move cut grass doesn't have an associated event script, it's also missing this check
Fix:
Added a script to cut grass like the other field effects. This will set field argument for the field effect animation (the player pulling the pokeball) to display before cutting grass.
Images
2025-01-04.18-23-20.mp4
Issue(s) that this PR fixes
Fixes #5766
People who collaborated with me in this PR
@Kasenn for finding the source of the issue, @hedara90 for the help with github
Feature(s) this PR does NOT handle:
Things to note in the release changelog:
Discord contact info
shachar700 (Shahar#3810)