Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly passing AGENT_HOSTNAME into the runner #68

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

judovana
Copy link
Collaborator

No description provided.

@judovana judovana force-pushed the skipOnNoAgent branch 2 times, most recently from e294d06 to 9ff24e7 Compare April 19, 2024 09:19
@zzambers
Copy link
Collaborator

Function checkProp is bit confusing as it is inverted check (true if null or not equal to "1"). Wouldn't be better not to have checkProp inverted and to use !checkProp(...) for negated check instead?

@judovana
Copy link
Collaborator Author

Actually when I was wrotting that, the whole method did not gave sense, as it is anything just not generic, and hsould be
parseCryptotestsSkipAgentTestsToBoolean or similarly

@judovana
Copy link
Collaborator Author

judovana commented Apr 22, 2024

Also I terribly dislike the 1 x anything else in the original code, but did not wanted to touch taht.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants