-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and mark as isolating for APT #113
Conversation
Using recommended global configuration
Plus new auto-value-annotations artifact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
Extension doesn't implement the new API to be marked as isolating. Also, have you tested incrementality of the processor? It doesn't look like it declares originating elements for the generated sources, which is at least required for isolating processors (not sure about aggregating ones). |
that's... really strange o_O. I had it locally for sure, probably got lost in the bouncing around of repos. For the processor - I was under the impression that aggregating processors didn't have to declare originating elements (since they could be from many places). I'll read up on the docs again |
I suppose that's implied here - https://docs.gradle.org/current/userguide/java_plugin.html It just says isolating must have one, but doesn't specify anything explicitly for aggregating ones. Do you know if we also need to declare the annotated factory interface itself as an originating element? (Assuming yes) Also - would extensions such as |
I've added the missing bits in #114 if you want to review |
Resolves a few things:
Resolves #112
Resolves #106