-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to incap helper #114
Changes from 6 commits
52be64c
4ae805c
49b02c3
17509d4
8654c8a
ec31fc6
364b785
e7b3104
ad8514b
1620b56
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,20 @@ | ||
apply plugin: 'net.ltgt.apt' | ||
apply plugin: 'java' | ||
apply plugin: 'maven-publish' | ||
|
||
sourceCompatibility = versions.java | ||
targetCompatibility = versions.java | ||
|
||
dependencies { | ||
apt "net.ltgt.gradle.incap:incap-processor:0.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
apt libraries.autoService | ||
compileOnly "net.ltgt.gradle.incap:incap:0.2" | ||
compileOnly libraries.autoService | ||
|
||
compile project(':auto-value-moshi-annotations') | ||
compile libraries.javaPoet | ||
compile libraries.autoValue | ||
compile libraries.autoValueAnnotations | ||
compileOnly libraries.autoService | ||
compile libraries.autoCommon | ||
compile libraries.moshi | ||
|
||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should revert that change, and use
annotationProcessor
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when I use that, it fails on CI due to not finding generated classes - https://travis-ci.org/rharter/auto-value-moshi/builds/456470849?utm_source=github_status&utm_medium=notification
I tried this just in case, and sure enough it did seem to fix it. Any sense on why it only happens in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was because auto-service wasn't in the processor path anymore at that commit.
At a minimum you could revert the
annotationProcessor
→apt
change, whether usingnet.ltgt.apt
or not (it will setupoptions.annotationProcessorGeneratedSourcesDirectory
, but this is useless here as those processors only generate resources; see the project's README to determine whether it's useful for you or not, in this specific case, it's not).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
364b785