Push to talk #82
Open
Push to talk #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got scared by the failed test. |
|
Will this allow assist activation from a button press / service call from HA? If so, I'd be willing to test this, as I'm very interested in getting that to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try on implementing #5 push to talk for review.
I'm pretty confident on the satellite side(bi-directional event service) but not so sure on the 2mic side with the callback and async. Instead of trying to find the perfect solution, I'm posting here so more people can review and test.There's also minor changes in logging to help folks troubleshoot as per some of the open issues.