Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom lightbeams #178

Closed

Conversation

Jeremy-Vidaurri
Copy link
Contributor

@Jeremy-Vidaurri Jeremy-Vidaurri commented Aug 14, 2024

Fixes #98

Adds a "Illumination Style" option when "Illuminate rooms" is not set to off. The options for this are:

  • Default: Plain old white lightbeams
  • Collectibles: Red for Strawberries, Green for Flags (buttons and whatnot), Yellow for keys
  • Custom: The user can input a 6 digit hex code
  • Random: Each hole has a different random color

So in its current state, "collectibles" does not work for repeated rooms as the repeated room will just override the hole objectives so I disabled it for now. I also left room for gems to be added but idk about adding them as it may take out the puzzle aspect of labyrinth.

For the rulesets, I think A-D should use "collectibles", E-F should use "default", and G-H can use "collectibles" or "default", but I'll wait to add any of that until you decide

@Jeremy-Vidaurri
Copy link
Contributor Author

still needs a bit more testing. Seems that hole objectives can stick between randos

@Jeremy-Vidaurri
Copy link
Contributor Author

Jeremy-Vidaurri commented Aug 17, 2024

the more I look at this, the more I want to change how I did it.

The current issue I'm seeing is that when a collectible is placed in a room that already exists, the path between the key door and the key aren't lit up properly. The way I think this can be solved is by using a generic AddObjectiveToPath function (or something similar) that traverses from the key to the key door and adds the objective to each path. I'm not 100% certain how feasible that is though.

This might make it easier to add into labyrinth for later use

@Jeremy-Vidaurri Jeremy-Vidaurri marked this pull request as draft August 27, 2024 21:46
@Jeremy-Vidaurri
Copy link
Contributor Author

ok so I'm starting full-time work so I will probably abandon this pr for a while :(

For future reference: Do a simple path finding alg to get path from key/flag to the room that has that as a req. Need to figure out how to make hubs/collectibles/all+collectibles show better. Perhaps a single toggle for show collectibles that simply tacks onto the current illumination.

@Jeremy-Vidaurri
Copy link
Contributor Author

Upon attempting this again. Fuck this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom light beams
1 participant