fix: Update settings on go #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't appear to mess it up. Should be good to go |
|
This shouldn't break anything on the h2h side. Only potential issue is that starting rando through h2h might cause the setting used for the h2h match to get saved and show up as the initial settings if you then go into rando the normal way, but i am not able to test it at the moment |
|
Eh, I don’t see that as much of an issue tbh. Say someone gets a fun seed in H2H and wants to play it back, they can just go into rando and get the seed that way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182 . I haven't tested whether this messes up @corkr900 s H2H mod