Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/profile.d: Add profiles for KDE & Kinoite Spins #3577

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

travier
Copy link
Contributor

@travier travier commented Aug 25, 2021

Both profiles are based on Workstation but use the generic Fedora Linux
branding until we make specific ones for those two spins.

Fedora Kinoite is a new Fedora variant similar to Fedora Silverblue,
introduced in Fedora 35.

See https://fedoraproject.org/wiki/Changes/Fedora_Kinoite

@travier travier marked this pull request as draft August 25, 2021 17:11
@travier
Copy link
Contributor Author

travier commented Aug 25, 2021

Marking as draft as I'm not sure exactly what impact this would have.

@poncovka poncovka changed the base branch from master to f35-devel August 26, 2021 15:39
@poncovka poncovka changed the base branch from f35-devel to master August 26, 2021 15:40
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to use configuration defaults of Fedora Workstation. It will hide some configuration screens in the summary hub and change the look of the user interface. See: https://github.com/rhinstaller/anaconda/blob/master/data/profile.d/fedora-workstation.conf

Could you please add a test for this profile in the test_fedora_profiles function of the ProfileConfigurationTestCase class? It will start to validate the configuration file.

If you want this change in F35 Beta, you will need to report a bug for Anaconda and ask for an exception. If you want it in F35, we will need to port it to f35-devel branch.

data/profile.d/fedora-kinoite.conf Outdated Show resolved Hide resolved
@poncovka poncovka added the master Please, use the `f39` label instead. label Aug 26, 2021
@travier travier force-pushed the kinoite branch 2 times, most recently from 3ac699f to 9f994a0 Compare August 27, 2021 09:34
@poncovka
Copy link
Contributor

/kickstart-test --testtype smoke

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@Conan-Kudo
Copy link
Contributor

You don't want to do this, we don't have an equivalent to gnome-initial-setup yet to make this work. That's why we haven't done it yet.

@travier
Copy link
Contributor Author

travier commented Aug 27, 2021

Hum, is initial-setup-gui not enough?

@travier travier changed the title data/profile.d: Add Fedora Kinoite profile data/profile.d: Add profiles for KDE & Kinoite Spins Aug 27, 2021
@Conan-Kudo
Copy link
Contributor

That's controlled by the Anaconda configuration. So it's just broken.

@travier
Copy link
Contributor Author

travier commented Aug 27, 2021

That's controlled by the Anaconda configuration. So it's just broken.

Any pointer to what needs fixing so that I can take a look?

@poncovka
Copy link
Contributor

That's controlled by the Anaconda configuration. So it's just broken.

Any pointer to what needs fixing so that I can take a look?

There was no use case for that so far, we need to figure out how to approach the issue. As a temporary workaround, we could reset the hidden_spokes option in the initial setup configuration file. See: https://github.com/rhinstaller/initial-setup/blob/master/data/10-initial-setup.conf

@poncovka
Copy link
Contributor

Actually, the initial setup doesn't use VARIANT_ID to load profile configuration files. It uses only ID, so I don't understand how it is broken. It should use the fedora configuration profile for all variants of Fedora. See: https://github.com/rhinstaller/initial-setup/blob/1ba27b4d9db7de2a46e5f208cdab65efb07c927a/initial_setup/__init__.py#L110-L112

data/profile.d/fedora-kinoite.conf Outdated Show resolved Hide resolved
@M4rtinK
Copy link
Contributor

M4rtinK commented Aug 30, 2021

There was no use case for that so far, we need to figure out how to approach the issue. As a temporary workaround, we could reset the hidden_spokes option in the initial setup configuration file. See: https://github.com/rhinstaller/initial-setup/blob/master/data/10-initial-setup.conf

Agreed - maybe have initial setup specific variant of hidden_spokes so that both can be set separately?

And in general, I agree this is something Initial Setup should handle & I'm ready to help as Initial Setup maintainer.

Both profiles are based on Fedora with the generic Fedora Linux branding
until we make specific ones for those two spins.

Fedora Kinoite is a new Fedora variant similar to Fedora Silverblue,
introduced in Fedora 35.

See https://fedoraproject.org/wiki/Changes/Fedora_Kinoite
@travier
Copy link
Contributor Author

travier commented Sep 3, 2021

OK, I've updated this one to mirror the workstation settings while keeping things independent until we figure out where we can share more.
As I don't think this will change much for F35, let's keep it for master only and I'll try to work on fixing the initial setup issue. Tracking issue: rhinstaller/initial-setup#136

@poncovka poncovka self-assigned this Sep 6, 2021
@poncovka poncovka added the manual testing required This issue can't be merged without manual testing label Sep 6, 2021
@poncovka
Copy link
Contributor

poncovka commented Sep 6, 2021

/kickstart-test --testtype smoke

@poncovka
Copy link
Contributor

poncovka commented Sep 6, 2021

Agreed - maybe have initial setup specific variant of hidden_spokes so that both can be set separately?

That makes zero sense. I am not going to support two versions of configuration options. If we are not able to use Anaconda's profiles in Initial Setup, then Initial Setup should have its own profiles.

@poncovka
Copy link
Contributor

poncovka commented Sep 6, 2021

Actually, the initial setup doesn't use VARIANT_ID to load profile configuration files. It uses only ID, so I don't understand how it is broken. It should use the fedora configuration profile for all variants of Fedora. See: https://github.com/rhinstaller/initial-setup/blob/1ba27b4d9db7de2a46e5f208cdab65efb07c927a/initial_setup/__init__.py#L110-L112

It means that #3577 (comment) is not true and you can set hidden_spokes in your profiles, because Initial Setup won't use them. The current support should be sufficient for your use case.

@travier
Copy link
Contributor Author

travier commented Sep 21, 2021

I think this one should be ready. I will try to work on the suggestion from rhinstaller/initial-setup#136 (comment) in a different PR.

@poncovka poncovka removed the manual testing required This issue can't be merged without manual testing label Sep 21, 2021
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@poncovka poncovka merged commit 959f211 into rhinstaller:master Sep 21, 2021
@travier travier deleted the kinoite branch September 22, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
Development

Successfully merging this pull request may close these issues.

5 participants