-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data/profile.d: Add profiles for KDE & Kinoite Spins #3577
Conversation
Marking as draft as I'm not sure exactly what impact this would have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems reasonable to use configuration defaults of Fedora Workstation. It will hide some configuration screens in the summary hub and change the look of the user interface. See: https://github.com/rhinstaller/anaconda/blob/master/data/profile.d/fedora-workstation.conf
Could you please add a test for this profile in the test_fedora_profiles
function of the ProfileConfigurationTestCase
class? It will start to validate the configuration file.
If you want this change in F35 Beta, you will need to report a bug for Anaconda and ask for an exception. If you want it in F35, we will need to port it to f35-devel
branch.
3ac699f
to
9f994a0
Compare
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
You don't want to do this, we don't have an equivalent to |
Hum, is |
That's controlled by the Anaconda configuration. So it's just broken. |
Any pointer to what needs fixing so that I can take a look? |
There was no use case for that so far, we need to figure out how to approach the issue. As a temporary workaround, we could reset the |
Actually, the initial setup doesn't use |
Agreed - maybe have initial setup specific variant of And in general, I agree this is something Initial Setup should handle & I'm ready to help as Initial Setup maintainer. |
Both profiles are based on Fedora with the generic Fedora Linux branding until we make specific ones for those two spins. Fedora Kinoite is a new Fedora variant similar to Fedora Silverblue, introduced in Fedora 35. See https://fedoraproject.org/wiki/Changes/Fedora_Kinoite
OK, I've updated this one to mirror the workstation settings while keeping things independent until we figure out where we can share more. |
/kickstart-test --testtype smoke |
That makes zero sense. I am not going to support two versions of configuration options. If we are not able to use Anaconda's profiles in Initial Setup, then Initial Setup should have its own profiles. |
It means that #3577 (comment) is not true and you can set |
I think this one should be ready. I will try to work on the suggestion from rhinstaller/initial-setup#136 (comment) in a different PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Both profiles are based on Workstation but use the generic Fedora Linux
branding until we make specific ones for those two spins.
Fedora Kinoite is a new Fedora variant similar to Fedora Silverblue,
introduced in Fedora 35.
See https://fedoraproject.org/wiki/Changes/Fedora_Kinoite