-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: Add additional information for EFI systems #5808
base: rhel-10
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstodola do we need a RHEL ticket for this backport?
Yes, we need a ticket, since the script is included in the RHEL installation environment. I've created the ticket: https://issues.redhat.com/browse/RHEL-55129 @jcpunk please update the commit message and add a line: |
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/kickstart-test --testtype smoke |
For some reason the JIRA ticket got assigned to me... since I don't work at RH I find that odd. Figured I'd note it here in case that is blocking things. |
Oops sorry for the noise. Feel free to ignore. |
@KKoukiou I think this is a merge candidate :) |
We want to first cover it with kickstart tests, this is the task that you will be working on as we agreed :) |
I'm not sure how I'd test this with kickstart since it is a tool for user's to capture logs and system state when things go wrong. |
From what I've looked at breifly, I'd suggest running Maybe it would be good to add this to some existing suitable test if there is some (I doubt so). Or we could create a new one for such cases, like If you want I can take care of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running in RHEL 10 environment I see these errors:
blkid: invalid option -- ':'
Try 'blkid --help' for more information.
Warning: Unable to open /dev/sr0 read-write (Read-only file system). /dev/sr0
has been opened read-only.
Error: /dev/sr0: unrecognised disk label
Warning: Unable to open /dev/sr1 read-write (Read-only file system). /dev/sr1
has been opened read-only.
Error: /dev/sr1: unrecognised disk label
blkid: unrecognized option '--output-all'
Try 'blkid --help' for more information.
Fixes should get forwardported to Fedora or maybe resolved there first. |
Synced log-capture file with master. Resolves: RHEL-55129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on RHEL10 boot.iso it works.
Backport partition information from #5765
Please finalize the master version first and backport when ready here; it's confusing to get reviews on all branches.