Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Add additional information for EFI systems #5808

Open
wants to merge 1 commit into
base: rhel-10
Choose a base branch
from

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Aug 6, 2024

Backport partition information from #5765

Please finalize the master version first and backport when ready here; it's confusing to get reviews on all branches.

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstodola do we need a RHEL ticket for this backport?

@jstodola
Copy link
Contributor

Yes, we need a ticket, since the script is included in the RHEL installation environment. I've created the ticket: https://issues.redhat.com/browse/RHEL-55129

@jcpunk please update the commit message and add a line:
Resolves: RHEL-55129
That should be enough from your side. Thanks.

@jcpunk
Copy link
Contributor Author

jcpunk commented Aug 19, 2024

Added

Copy link
Contributor

@elkoniu elkoniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elkoniu
Copy link
Contributor

elkoniu commented Oct 7, 2024

/kickstart-test --testtype smoke

@jcpunk
Copy link
Contributor Author

jcpunk commented Oct 16, 2024

For some reason the JIRA ticket got assigned to me... since I don't work at RH I find that odd. Figured I'd note it here in case that is blocking things.

@KKoukiou
Copy link
Contributor

For some reason the JIRA ticket got assigned to me... since I don't work at RH I find that odd. Figured I'd note it here in case that is blocking things.

Oops sorry for the noise. Feel free to ignore.

@elkoniu
Copy link
Contributor

elkoniu commented Oct 16, 2024

@KKoukiou I think this is a merge candidate :)

@KKoukiou
Copy link
Contributor

For some reason the JIRA ticket got assigned to me... since I don't work at RH I find that odd. Figured I'd note it here in case that is blocking things.

We want to first cover it with kickstart tests, this is the task that you will be working on as we agreed :)

@jcpunk
Copy link
Contributor Author

jcpunk commented Oct 17, 2024

I'm not sure how I'd test this with kickstart since it is a tool for user's to capture logs and system state when things go wrong.

@rvykydal
Copy link
Contributor

rvykydal commented Oct 23, 2024

From what I've looked at breifly, I'd suggest running /usr/libexec/anaconda/log-capture in %post --nochroot of the kstest and checking the stderr if it is expected (ideally empty but that needs some fix first). To see if the tooling we call is available on the image.

Maybe it would be good to add this to some existing suitable test if there is some (I doubt so). Or we could create a new one for such cases, like tools.

If you want I can take care of it.

scripts/log-capture Outdated Show resolved Hide resolved
scripts/log-capture Outdated Show resolved Hide resolved
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running in RHEL 10 environment I see these errors:

blkid: invalid option -- ':'
Try 'blkid --help' for more information.
Warning: Unable to open /dev/sr0 read-write (Read-only file system).  /dev/sr0
has been opened read-only.
Error: /dev/sr0: unrecognised disk label
Warning: Unable to open /dev/sr1 read-write (Read-only file system).  /dev/sr1
has been opened read-only.
Error: /dev/sr1: unrecognised disk label
blkid: unrecognized option '--output-all'
Try 'blkid --help' for more information.

@jkonecny12
Copy link
Member

Fixes should get forwardported to Fedora or maybe resolved there first.

@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Oct 29, 2024
Synced log-capture file with master.

Resolves: RHEL-55129
@KKoukiou KKoukiou removed the blocked Don't merge this pull request! label Nov 25, 2024
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on RHEL10 boot.iso it works.

@KKoukiou KKoukiou added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-10
Development

Successfully merging this pull request may close these issues.

6 participants