Merge pull request #30 from SentulAsia/develop

done unit test for all public method
ricardopereira · Jun 2, 2019 · fce59cf · fce59cf
2 parents da797d5 + df4cac4
commit fce59cf
Show file tree

Hide file tree

Showing 3 changed files with 148 additions and 48 deletions.
diff --git a/ColiseuPlayer.xcodeproj/project.pbxproj b/ColiseuPlayer.xcodeproj/project.pbxproj
@@ -403,10 +403,6 @@
 		D788F7A819E69E5600C04099 /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-				FRAMEWORK_SEARCH_PATHS = (
-					"$(SDKROOT)/Developer/Library/Frameworks",
-					"$(inherited)",
-				);
 				GCC_PREPROCESSOR_DEFINITIONS = (
 					"DEBUG=1",
 					"$(inherited)",
@@ -422,10 +418,6 @@
 		D788F7A919E69E5600C04099 /* Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-				FRAMEWORK_SEARCH_PATHS = (
-					"$(SDKROOT)/Developer/Library/Frameworks",
-					"$(inherited)",
-				);
 				INFOPLIST_FILE = ColiseuPlayerTests/Info.plist;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
 				PRODUCT_BUNDLE_IDENTIFIER = "eu.ricardopereira.$(PRODUCT_NAME:rfc1034identifier)";

diff --git a/ColiseuPlayer/ColiseuPlayer.swift b/ColiseuPlayer/ColiseuPlayer.swift
@@ -105,7 +105,14 @@ public protocol ColiseuPlayerDataSource: class
 /// Specifies the repeat type of an audio player.
 public enum ColiseuPlayerRepeat: Int
 {
-    case none = 0, one, all
+    /// Represents will not repeat.
+    case none = 0
+
+    /// Represents will repeat once.
+    case one
+
+    /// Represents will always repeat.
+    case all
 }
 
 /// An audio player builder, to make it mockable by test
@@ -206,7 +213,7 @@ public class ColiseuPlayer: NSObject
         return false
     }
 
-    // MARK: - Init
+    // MARK: - Initializers
 
     public override init()
     {
@@ -226,7 +233,7 @@ public class ColiseuPlayer: NSObject
 
     // MARK: - Session
 
-    /// Activates your app’s audio session using the specified options.
+    /// Activates your app’s audio session.
     public func startSession()
     {
         do {
@@ -243,7 +250,7 @@ public class ColiseuPlayer: NSObject
         }
     }
 
-    /// Deactivates your app’s audio session using the specified options.
+    /// Deactivates your app’s audio session.
     public func stopSession()
     {
         do {
@@ -389,11 +396,9 @@ public class ColiseuPlayer: NSObject
     /// Stops playback and undoes the setup needed for playback.
     public func stopSong()
     {
-        if self.audioPlayer == nil || !self.isPlaying {
-            return
-        }
+        guard let audioPlayer = self.audioPlayer, self.isPlaying else { return }
 
-        self.audioPlayer!.stop()
+        audioPlayer.stop()
         if let event = self.playerDidStop {
             event()
         }
@@ -442,7 +447,7 @@ public class ColiseuPlayer: NSObject
     }
 
     // MARK: - ColiseuPlayerDelegate
-    
+
     /// Tells the object when a remote-control event is received.
     ///
     /// - Parameter event: An event object encapsulating a remote-control command. Remote-control events have a type of UIEvent.EventType.remoteControl.