Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to use SHA1 over MD5 to comply with FIPS #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updates to use SHA1 over MD5 to comply with FIPS #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/RecentMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ public int Prune()
/// The binary representation of a message.
/// </param>
/// <returns>
/// The Base64 encoding of the MD5 hash of the <paramref name="message"/>.
/// The Base64 encoding of the SHA1 hash of the <paramref name="message"/>.
/// </returns>
public string GetId(byte[] message)
{
// MD5 is okay because the hash is not used for security.
using (HashAlgorithm hasher = MD5.Create())
// SHA is FIPS compliant, as opposed to MD5.
using (HashAlgorithm hasher = SHA1.Create())
{
return Convert.ToBase64String(hasher.ComputeHash(message));
}
Expand Down