Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support redis 5.0 commands #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dselivanov
Copy link

  • fix problems with json parsing for API generation
  • regenerate API to support redis 5.0 (redis doc commit db399bb9f3871a749bc14cc9d60761a7bfd73cf8)
  • add .o. .so to gitignore

- regenerate API to support redis 5.0 (redis doc commit db399bb9f3871a749bc14cc9d60761a7bfd73cf8)
- add .o. .so to gitignore
@dselivanov
Copy link
Author

It seems signatures of some functions were change, thats why tests fail. I will update tests.

@dseynaev
Copy link

Hi @dselivanov did you get this working? I installed your fork but I'm having some issues:

> r <- hiredis()
> r$XLEN("mystream")
Error in redis_command(ptr, cmd) : ERR unknown command 'XLEN'
> r$XADD("mystream", "*", "sensor-id", 1234)
Error in redis_command(ptr, cmd) : ERR unknown command 'XADD'

Can I help with anything?

@dselivanov
Copy link
Author

@dseynaev as I remember it was working fine. Do you have redis 5 running? looks like you redis version is < 5.0

@dseynaev
Copy link

@dselivanov I was indeed blindly assuming that my local redis version was recent enough... upgrading fixed it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants