Added the account repository interface

rickintveld · Sep 5, 2024 · 59ab3fd · 59ab3fd
1 parent dbf2390
commit 59ab3fd
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 9 deletions.
diff --git a/src/Action/Account/FetchAccounts.php b/src/Action/Account/FetchAccounts.php
@@ -5,18 +5,18 @@
 namespace App\Action\Account;
 
 use App\Action\ActionInterface;
+use App\Contract\Repository\AccountRepositoryInterface;
 use App\Contract\Repository\MyFxBookRepositoryInterface;
 use App\Dto\Aggregator\AggregateInterface;
 use App\Event\CreateAccountEvent;
 use App\Event\UpdateAccountEvent;
 use App\Exception\AccountNotFoundException;
-use App\Repository\AccountRepository;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 final readonly class FetchAccounts implements ActionInterface
 {
     public function __construct(
-        private AccountRepository $accountRepository,
+        private AccountRepositoryInterface $accountRepository,
         private EventDispatcherInterface $eventBus,
         private MyFxBookRepositoryInterface $myFxBookRepository
     ) {}

diff --git a/src/Contract/Repository/AccountRepositoryInterface.php b/src/Contract/Repository/AccountRepositoryInterface.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Contract\Repository;
+
+use App\Entity\Account;
+
+/**
+ * @method Account|null find($id, $lockMode = null, $lockVersion = null)
+ * @method Account|null findOneBy(array $criteria, array $orderBy = null)
+ * @method Account[]    findAll()
+ * @method Account[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
+ */
+interface AccountRepositoryInterface {}
diff --git a/src/Repository/AccountRepository.php b/src/Repository/AccountRepository.php
@@ -4,6 +4,7 @@
 
 namespace App\Repository;
 
+use App\Contract\Repository\AccountRepositoryInterface;
 use App\Entity\Account;
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
@@ -16,7 +17,7 @@
  * @method Account[]    findAll()
  * @method Account[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
  */
-class AccountRepository extends ServiceEntityRepository
+class AccountRepository extends ServiceEntityRepository implements AccountRepositoryInterface
 {
     public function __construct(ManagerRegistry $registry)
     {

diff --git a/src/Subscriber/CreateAccountEventListener.php b/src/Subscriber/CreateAccountEventListener.php
@@ -4,10 +4,10 @@
 
 namespace App\Subscriber;
 
+use App\Contract\Repository\AccountRepositoryInterface;
 use App\Entity\Account;
 use App\Event\CreateAccountEvent;
 use App\Event\UpdateAccountEvent;
-use App\Repository\AccountRepository;
 use App\Serializer\Serializer;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\EventDispatcher\Attribute\AsEventListener;
@@ -17,7 +17,7 @@
 class CreateAccountEventListener
 {
     public function __construct(
-        private readonly AccountRepository $accountRepository,
+        private readonly AccountRepositoryInterface $accountRepository,
         private readonly EntityManagerInterface $entityManager,
         private readonly EventDispatcherInterface $eventBus,
         private readonly Serializer $serializer

diff --git a/tests/Action/Account/FetchAccountsTest.php b/tests/Action/Account/FetchAccountsTest.php
@@ -3,12 +3,12 @@
 namespace App\Tests\Action\Account;
 
 use App\Action\Account\FetchAccounts;
+use App\Contract\Repository\AccountRepositoryInterface;
 use App\Contract\Repository\MyFxBookRepositoryInterface;
 use App\Dto\Aggregator\AggregateRoot;
 use App\Entity\Account;
 use App\Event\CreateAccountEvent;
 use App\Event\UpdateAccountEvent;
-use App\Repository\AccountRepository;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
@@ -19,10 +19,10 @@ public function testAction(): void
         $account = $this->createMock(Account::class);
         $account->method('getAccountId')->willReturn(1);
 
-        $accountRepository = $this->getMockBuilder(AccountRepository::class)->disableOriginalConstructor()->getMock();
+        $accountRepository = $this->getMockBuilder(AccountRepositoryInterface::class)->addMethods(['findAll'])->getMock();
         $accountRepository->expects($this->once())->method('findAll')->willReturn([$account]);
 
-        $eventBus = $this->getMockBuilder(EventDispatcherInterface::class)->disableOriginalConstructor()->getMock();
+        $eventBus = $this->getMockBuilder(EventDispatcherInterface::class)->getMock();
         $eventBus->expects($this->exactly(3))->method('dispatch')->with($this->callback(function ($object) {
             if ($object instanceof CreateAccountEvent) {
                 return true;
@@ -38,7 +38,7 @@ public function testAction(): void
         $myFxBookRepository->expects($this->once())->method('accounts')->with('123abc#')->willReturn([['accountId' => 1], ['accountId' => 2]]);
 
         /**
-         * @var AccountRepository $accountRepository
+         * @var AccountRepositoryInterface $accountRepository
          * @var EventDispatcherInterface $eventBus
          * @var MyFxBookRepositoryInterface $myFxBookRepository
          */