Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tests tolerate whispace changes in datetime format #1874

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

exyi
Copy link
Member

@exyi exyi commented Oct 20, 2024

ICU update probably caused different whitespace
being generated before AM/PM (no whitespace,
&nbsp, and simple space are all possible).

@exyi exyi added this to the Version 4.3 milestone Oct 20, 2024
@exyi exyi changed the title UI tests tollerate whispace changes in datetime format UI tests tolerate whispace changes in datetime format Oct 24, 2024
@exyi
Copy link
Member Author

exyi commented Nov 3, 2024

Seems like github actions got their sh*t together and this is no longer necessary

@exyi exyi closed this Nov 3, 2024
@exyi exyi reopened this Dec 20, 2024
ICU update probably caused different whitespace
being generated before AM/PM (no whitespace,
&nbsp, and simple space are all possible).
@exyi exyi force-pushed the fix-datetimefmt-uitests branch from 4da558e to 3991509 Compare December 20, 2024 13:11
@exyi exyi merged commit 5b54b96 into main Dec 20, 2024
13 of 14 checks passed
@exyi exyi deleted the fix-datetimefmt-uitests branch December 20, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants