Fix leaking of original object from ko.observableArray #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko.observableArray would leak the original object to its 'arrayChanges' subscribers when instance method (such as 'push', 'splice') was used to modify the array. Knockout would pre-compute the diff passed to the subscribers before our validator was called. * Knockout updated to b7b150a6 to remove an optimization which was the primary cause * Made FakeObservableObject internal properties non-enumerable so make sure they don't propagate through coercer when assigned into an array.
exyi
commented
Dec 15, 2024
tomasherceg
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ko.observableArray would leak the original object to its 'arrayChanges' subscribers when instance method (such as 'push', 'splice') was used to modify the array. Knockout would pre-compute the diff passed to the subscribers before our validator was called.